[vectorIntrinsics+mask] RFR: 8264563: Add masked vector intrinsics for binary/store operations [v5]

Xiaohong Gong xgong at openjdk.java.net
Wed Apr 21 10:06:45 UTC 2021


On Wed, 21 Apr 2021 09:02:28 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove null checking for the mask argument in API implementation
>
> src/hotspot/share/opto/vectornode.cpp line 755:
> 
>> 753:     }
>> 754:   }
>> 755:   return StoreNode::Ideal(phase, can_reshape);
> 
> Can you elaborate, please, why this change is needed?

Oh, I just noticed that the `StoreVectorMaskedNode` is extended from `StoreNode`, which has some optimizations in `StoreNode::Ideal`. I'm worried that overriding the `StoreNode::Ideal` for `StoreVectorMaskedNode` might miss the optimizations in `StoreNode::Ideal`. I will reconsider this in more details. Thanks!

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/57


More information about the panama-dev mailing list