[vectorIntrinsics+mask] RFR: 8264563: Add masked vector intrinsics for binary/store operations [v5]
Vladimir Ivanov
vlivanov at openjdk.java.net
Wed Apr 21 11:21:46 UTC 2021
On Wed, 21 Apr 2021 10:03:54 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> src/hotspot/share/opto/vectornode.cpp line 755:
>>
>>> 753: }
>>> 754: }
>>> 755: return StoreNode::Ideal(phase, can_reshape);
>>
>> Can you elaborate, please, why this change is needed?
>
> Oh, I just noticed that the `StoreVectorMaskedNode` is extended from `StoreNode`, which has some optimizations in `StoreNode::Ideal`. I'm worried that overriding the `StoreNode::Ideal` for `StoreVectorMaskedNode` might miss the optimizations in `StoreNode::Ideal`. I will reconsider this in more details. Thanks!
It makes sense to handle it separately and fix it in the mainline.
-------------
PR: https://git.openjdk.java.net/panama-vector/pull/57
More information about the panama-dev
mailing list