[foreign-jextract] RFR: 8261906: Improve jextract support for virtual functions [v6]

[Jorn Vernee]

On Thu, 4 Mar 2021 16:33:50 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add call to Utils.javaSafeIdentifier
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/OutputFactory.java line 264:
> 
>> 262:                 Type.Function f = getAsFunctionPointer(param.type());
>> 263:                 if (f != null) {
>> 264:                     String name = funcTree.name() + "$" + (param.name().isEmpty() ? "x" + i : param.name());
> 
> This seems to let the name of the functional interface class depend on the parameter name? I thought we did _not_ want to do that?

Ah, I see it's pre-existing, sorry. I guess we can take care of it in another patch.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/456