[foreign-jextract] RFR: 8261906: Improve jextract support for virtual functions [v6]

[Maurizio Cimadamore]

On Thu, 4 Mar 2021 16:41:04 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add call to Utils.javaSafeIdentifier
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/OutputFactory.java line 408:
> 
>> 406:                 varInfo = VarInfo.ofFunctionalPointerVar(clazz, layout, Utils.javaSafeIdentifier(funcTypedef.get()));
>> 407:             }
>> 408:         }
> 
> I see what you mean here. I guess we expect these functional interface classes to be generated when visiting the typedef?

yeah - not great - as the functional interface name might differ significantly from the typedef name in case of clashes...

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/456