[foreign-memaccess+abi] RFR: 8263018: Improve API for lifecycle of native resources [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Mar 10 17:27:21 UTC 2021


On Fri, 5 Mar 2021 16:32:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix issue in ResourceScope::ofShared() javadoc
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 694:
> 
>> 692:          * <p>
>> 693:          * If this method needs to allocate native memory for the va list, it will use
>> 694:          * the given {@code NativeAllocator} to do so.
> 
> This looks out-of-date

I don't seem to have this in my code - probably forgot to push all my javadoc changes

> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/LibraryLookup.java line 49:
> 
>> 47:  * In cases where a client wants to create a memory segment out of a lookup symbol, the client might want to attach the
>> 48:  * lookup symbol to the newly created segment, so that the symbol will be kept reachable as long as the memory segment
>> 49:  * is reachable; this can be achieved by creating the segment using the {@link MemoryAddress#asSegmentRestricted(long, Runnable, ResourceScope)}.
> 
> The below example should be updated as well.

Same here

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/466


More information about the panama-dev mailing list