[foreign-memaccess+abi] RFR: 8263018: Improve API for lifecycle of native resources [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Thu Mar 11 11:53:35 UTC 2021
On Wed, 10 Mar 2021 14:10:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix issue in ResourceScope::ofShared() javadoc
>
> Amazing work! (it was pleasure reading this) I think this is a great step forward. MemorySegment is now a much more minimal API, and lifetime concerns are nicely contained in ResourceScope.
>
> I tried to be very thorough with the review, since I was not that involved with the design this time around (working on upcall specialization at the same time). Also just asking some questions here and there to make sure my understanding is correct. But, a lot of the comments are just small nits.
I think I've address all of @JornVernee comments - thanks again for the in-depth review!
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/466
More information about the panama-dev
mailing list