[foreign-memaccess+abi] RFR: 8277657: OptimizedEntryBlob should extend RuntimeBlob directly

[Maurizio Cimadamore]

On Thu, 25 Nov 2021 14:42:25 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> This small refactoring makes OptimizedEntryBlob extend RuntimeBlob instead of BufferBlob.
> 
> The motivation for doing this is that we don't want to inherit behavior from BufferBlob by accident which is not appropriate for OptimizedEntryBlob, which has happened in the past.
> 
> This patch also reverts an earlier fix by Nick which made BufferBlob sub classes pass their header size through the BufferBlob constructor to RuntimeBlob's constructor, since this is no longer needed with this patch.

Generally looks good - one bit of refactoring looks suspicious.

src/hotspot/share/code/codeBlob.cpp line 297:

> 295: 
> 296: AdapterBlob::AdapterBlob(int size, CodeBuffer* cb) :
> 297:   BufferBlob("I2C/C2I adapters", size, cb) {

the header size here used to be sizeof(AdapterBlob), but now is sizeof(BufferBlob) - is that an issue?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/617