[foreign-memaccess+abi] RFR: 8273905: Foreign API refresh [v4]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon Sep 20 10:26:56 UTC 2021
On Sat, 18 Sep 2021 21:28:08 GMT, Uwe Schindler <uschindler at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cleanup up code, following some IDEA suggestions.
>> * unused imports
>> * suggestions for new language features
>> * drop unused impl declarations
>> * removed size constructor parameter in value layout subclasses (except `OfAddress`)
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java line 1580:
>
>> 1578: Objects.requireNonNull(srcArray);
>> 1579: Objects.requireNonNull(dstSegment);
>> 1580: Objects.requireNonNull(dstLayout);
>
> same here: dstLayout's carrier type should be srcArray's type.
Good point(s) - I will fix.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/576
More information about the panama-dev
mailing list