[foreign-memaccess+abi] RFR: 8273905: Foreign API refresh [v5]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Mon Sep 20 10:48:13 UTC 2021


> As outlined in [1], there are areas of the foreign API we'd like to improve upon, such as:
> 
> * dereference: there is a mismatch between API points which create segments (which take a layout) and dereference API points, which do not take layouts
> 
> * role of `MemoryAddress`: in Java 17, `MemoryAddress` has become a stateful carrier, which is attached to a scope. This is inconvenient, as in most cases, a memory address is just a raw pointer that arises when interacting with native code.
> 
> * resource scopes: the API for scopes has too many flavors to pick from, many of which overlap. The fact that scopes and segment allocators are unrelated forces clients to introduce ad hoc conversions from scopes to allocators, and library developers to add overloads. Finally, the API for acquiring scopes doesn't work well with try-with-resources, and could also be simplified. 
> 
> I will add separate comments to explain how the API has changed to resolve the above issues.
> 
> [1] - https://mail.openjdk.java.net/pipermail/panama-dev/2021-September/014946.html

Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:

  Address review comments:
  * Fix spurious javadoc references to `MemoryLayouts`
  * Drop one more unused import
  * Add checks to `MemorySegment::copy`: array component should match layout carrier
  * Tweak exception thrown by `MemorySegment::copy` when an unsupported array is passed
  * Add simple negative tests to `TestArrayCopy`

-------------

Changes:
  - all: https://git.openjdk.java.net/panama-foreign/pull/576/files
  - new: https://git.openjdk.java.net/panama-foreign/pull/576/files/c4bf5b4b..fd58e930

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=576&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=576&range=03-04

  Stats: 40 lines in 3 files changed: 33 ins; 1 del; 6 mod
  Patch: https://git.openjdk.java.net/panama-foreign/pull/576.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/576/head:pull/576

PR: https://git.openjdk.java.net/panama-foreign/pull/576


More information about the panama-dev mailing list