[foreign-jextract] RFR: 8281764: jextract does not generate parameter names for function pointer typedefs [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon Feb 21 10:26:15 UTC 2022
On Mon, 21 Feb 2022 09:34:59 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:
>> Propagating TypedefDecl's ParmDecl child cursors to Types.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>
> cleanup based on code review comments
Marked as reviewed by mcimadamore (Committer).
src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/TreeMaker.java line 262:
> 260: Type.Function funcType = null;
> 261: boolean isFuncPtrType = false;
> 262: if (canonicalType instanceof Type.Function) {
I believe `OutputFactory::getAsFunctionPointer` as code that is similar to this (given a type, return it as a function type - following typedefs if necessary). Maybe we should move this into some util function and share?
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/646
More information about the panama-dev
mailing list