[foreign-jextract] RFR: 8281764: jextract does not generate parameter names for function pointer typedefs [v2]

[Athijegannathan Sundararajan]

On Mon, 21 Feb 2022 10:22:50 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup based on code review comments
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/TreeMaker.java line 262:
> 
>> 260:         Type.Function funcType = null;
>> 261:         boolean isFuncPtrType = false;
>> 262:         if (canonicalType instanceof Type.Function) {
> 
> I believe `OutputFactory::getAsFunctionPointer` as code that is similar to this (given a type, return it as a function type - following typedefs if necessary). Maybe we should move this into some util function and share?

That part of the code assumes all Types are properly resolved. In TreeMaker, we're in the middle TypeMaker's construction (resolution happens later).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/646