[foreign-preview] RFR: 8275648: Linker naming bikeshed [v2]

Jorn Vernee jvernee at openjdk.java.net
Wed Feb 23 13:50:27 UTC 2022


> Hi,
> 
> This PR renames several classes, functions, and files in the linker implementation. So far this has been avoided while the implementation was still being worked out. But now that we are moving to preview state, it is time to revisit these names.
> 
> Roughly speaking, the following name changes are applied:
> 
>   - ProgrammableInvoker           -> DowncallLinker
>   - ProgrammableUpcallHandler -> UpcallLinker
>   - 'native invoker'                      -> 'downcall stub'
>   - 'optimzed upcall stub'            -> 'upcall stub'
>   - OptimizedEntryBlob               -> UpcallStub
>   - optimized_entry_frame           -> upcall_stub_frame
> 
> Then, some source files in hotspot are also renamed as follows:
> 
>   - universalNativeInvoker* -> downcallLinker*
>   - universalUpcallHandler* -> upcallLinker*
>   - foreign_globals*             -> foreignGlobals* (to match existing convention)
>   
> I've also fixed up some outdated comments.
> 
> Thanks,
> Jorn

Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:

  Fix some indentation + remove old comment

-------------

Changes:
  - all: https://git.openjdk.java.net/panama-foreign/pull/654/files
  - new: https://git.openjdk.java.net/panama-foreign/pull/654/files/c8aceece..dc3e0d2b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=654&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=654&range=00-01

  Stats: 15 lines in 4 files changed: 0 ins; 6 del; 9 mod
  Patch: https://git.openjdk.java.net/panama-foreign/pull/654.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/654/head:pull/654

PR: https://git.openjdk.java.net/panama-foreign/pull/654


More information about the panama-dev mailing list