[foreign-preview] RFR: 8275648: Linker naming bikeshed [v2]

[Maurizio Cimadamore]

On Wed, 23 Feb 2022 13:50:27 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> This PR renames several classes, functions, and files in the linker implementation. So far this has been avoided while the implementation was still being worked out. But now that we are moving to preview state, it is time to revisit these names.
>> 
>> Roughly speaking, the following name changes are applied:
>> 
>>   - ProgrammableInvoker           -> DowncallLinker
>>   - ProgrammableUpcallHandler -> UpcallLinker
>>   - 'native invoker'                      -> 'downcall stub'
>>   - 'optimzed upcall stub'            -> 'upcall stub'
>>   - OptimizedEntryBlob               -> UpcallStub
>>   - optimized_entry_frame           -> upcall_stub_frame
>> 
>> Then, some source files in hotspot are also renamed as follows:
>> 
>>   - universalNativeInvoker* -> downcallLinker*
>>   - universalUpcallHandler* -> upcallLinker*
>>   - foreign_globals*             -> foreignGlobals* (to match existing convention)
>>   
>> I've also fixed up some outdated comments.
>> 
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix some indentation + remove old comment

Looks good - one suspicious reference to PUH (see comment)

src/hotspot/share/prims/upcallLinker.cpp line 131:

> 129: }
> 130: 
> 131: JVM_ENTRY(jlong, PUH_MakeUpcallStub(JNIEnv *env, jclass unused, jobject mh, jobject abi, jobject conv,

Isn't PUH a leftover of ProgrammableUpcallHandler? (here and elsewhere in this file)

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/654