[foreign-preview] RFR: 8275648: Linker naming bikeshed [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Feb 23 16:41:12 UTC 2022


On Wed, 23 Feb 2022 15:44:18 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> This PR renames several classes, functions, and files in the linker implementation. So far this has been avoided while the implementation was still being worked out. But now that we are moving to preview state, it is time to revisit these names.
>> 
>> Roughly speaking, the following name changes are applied:
>> 
>>   - ProgrammableInvoker           -> DowncallLinker
>>   - ProgrammableUpcallHandler -> UpcallLinker
>>   - 'native invoker'                      -> 'downcall stub'
>>   - 'optimzed upcall stub'            -> 'upcall stub'
>>   - OptimizedEntryBlob               -> UpcallStub
>>   - optimized_entry_frame           -> upcall_stub_frame
>> 
>> Then, some source files in hotspot are also renamed as follows:
>> 
>>   - universalNativeInvoker* -> downcallLinker*
>>   - universalUpcallHandler* -> upcallLinker*
>>   - foreign_globals*             -> foreignGlobals* (to match existing convention)
>>   
>> I've also fixed up some outdated comments.
>> 
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   PUH -> UL

All good on Linux.

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/654


More information about the panama-dev mailing list