[foreign-preview] Integrated: 8275648: Linker naming bikeshed

Jorn Vernee jvernee at openjdk.java.net
Wed Feb 23 16:55:08 UTC 2022


On Tue, 22 Feb 2022 18:05:33 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> This PR renames several classes, functions, and files in the linker implementation. So far this has been avoided while the implementation was still being worked out. But now that we are moving to preview state, it is time to revisit these names.
> 
> Roughly speaking, the following name changes are applied:
> 
>   - ProgrammableInvoker           -> DowncallLinker
>   - ProgrammableUpcallHandler -> UpcallLinker
>   - 'native invoker'                      -> 'downcall stub'
>   - 'optimzed upcall stub'            -> 'upcall stub'
>   - OptimizedEntryBlob               -> UpcallStub
>   - optimized_entry_frame           -> upcall_stub_frame
> 
> Then, some source files in hotspot are also renamed as follows:
> 
>   - universalNativeInvoker* -> downcallLinker*
>   - universalUpcallHandler* -> upcallLinker*
>   - foreign_globals*             -> foreignGlobals* (to match existing convention)
>   
> I've also fixed up some outdated comments.
> 
> Thanks,
> Jorn

This pull request has now been integrated.

Changeset: b1b2bcd2
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/b1b2bcd20743521dd0227534e420e121c85afb1f
Stats:     2181 lines in 76 files changed: 979 ins; 989 del; 213 mod

8275648: Linker naming bikeshed

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/654


More information about the panama-dev mailing list