[foreign-preview] RFR: 8281412: MemorySegment::map should live in FileChannel [v5]

Julia Boes jboes at openjdk.java.net
Fri Mar 11 13:07:48 UTC 2022


> This change moves the factory for mapped memory segments to `FileChannel`, as a new instance method `map`, which moves it closer to the existing `FileChannel::map` that returns a `MappedByteBuffer`.  
> 
> Tests are adjusted accordingly and a new test for custom file channels (that do/don't override the method) is added.

Julia Boes has updated the pull request incrementally with one additional commit since the last revision:

  minor punctuation fix

-------------

Changes:
  - all: https://git.openjdk.java.net/panama-foreign/pull/668/files
  - new: https://git.openjdk.java.net/panama-foreign/pull/668/files/737add2c..6f102df2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=668&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=668&range=03-04

  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/panama-foreign/pull/668.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/668/head:pull/668

PR: https://git.openjdk.java.net/panama-foreign/pull/668


More information about the panama-dev mailing list