[foreign-preview] RFR: 8281412: MemorySegment::map should live in FileChannel [v5]

Fri Mar 11 13:29:02 UTC 2022

On Fri, 11 Mar 2022 13:07:48 GMT, Julia Boes <jboes at openjdk.org> wrote:

>> This change moves the factory for mapped memory segments to `FileChannel`, as a new instance method `map`, which moves it closer to the existing `FileChannel::map` that returns a `MappedByteBuffer`.  
>> 
>> Tests are adjusted accordingly and a new test for custom file channels (that do/don't override the method) is added.
>
> Julia Boes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor punctuation fix

Looks good!

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/668