[foreign-preview] Integrated: 8281412: MemorySegment::map should live in FileChannel

Julia Boes jboes at openjdk.java.net
Fri Mar 11 13:50:02 UTC 2022


On Thu, 10 Mar 2022 14:05:32 GMT, Julia Boes <jboes at openjdk.org> wrote:

> This change moves the factory for mapped memory segments to `FileChannel`, as a new instance method `map`, which moves it closer to the existing `FileChannel::map` that returns a `MappedByteBuffer`.  
> 
> Tests are adjusted accordingly and a new test for custom file channels (that do/don't override the method) is added.

This pull request has now been integrated.

Changeset: c28366da
Author:    Julia Boes <jboes at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/c28366dabff60f3d57b4967b55ce7176c13aa3fb
Stats:     480 lines in 10 files changed: 315 ins; 111 del; 54 mod

8281412: MemorySegment::map should live in FileChannel

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/668


More information about the panama-dev mailing list