[foreign-memaccess+abi] RFR: 8270851: Logic for attaching/detaching native threads could be improved [v2]

[Maurizio Cimadamore]

On Mon, 28 Mar 2022 17:08:59 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Fix whitespaces
>>  - Merge branch 'foreign-memaccess+abi' into upcall_lazy_detach
>>  - Merge branch 'foreign-memaccess+abi' into upcall_lazy_detach
>>  - Remove whitespaces, fix indent
>>  - Lazily deattach native threads using thread local storage destructors
>
> src/hotspot/share/prims/universalUpcallHandler.cpp line 63:
> 
>> 61: // modelled after JavaCallWrapper::JavaCallWrapper
>> 62: JavaThread* ProgrammableUpcallHandler::on_entry(OptimizedEntryBlob::FrameData* context) {
>> 63:   JavaThread* thread = maybe_attach_and_get_thread(&context->should_detach);
> 
> I think the `should_detach` field can now be removed from `OptimizedEntryBlob::FrameData`

isn't that already the case in codeBlob.hpp ?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/570