[foreign-memaccess+abi] RFR: 8270851: Logic for attaching/detaching native threads could be improved [v2]

[Jorn Vernee]

On Mon, 28 Mar 2022 17:17:15 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/hotspot/share/prims/universalUpcallHandler.cpp line 63:
>> 
>>> 61: // modelled after JavaCallWrapper::JavaCallWrapper
>>> 62: JavaThread* ProgrammableUpcallHandler::on_entry(OptimizedEntryBlob::FrameData* context) {
>>> 63:   JavaThread* thread = maybe_attach_and_get_thread(&context->should_detach);
>> 
>> I think the `should_detach` field can now be removed from `OptimizedEntryBlob::FrameData`
>
> isn't that already the case in codeBlob.hpp ?

Oh, huh. You're right. I think those changes might have been hidden when I looked at the changes, since I already looked at them before (or maybe I just wasn't paying enough attention :) ). (Now I see it).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/570