[foreign-memaccess+abi] RFR: 8306668: Some foreign tests fail on x86

[Jorn Vernee]

On Fri, 21 Apr 2023 10:09:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Some foreign tests fail on x86, as a result of the changes in https://github.com/openjdk/panama-foreign/pull/775.
> This patch reverts the `long` -> `int` conversion logic in `Utils`, and it also fixes the following:
> * a new microbenchmark fails compilation on x86 because of a bad cast from pointer to long
> * exclude WindowsCallArrangerTest on x86
> 
> I've tested this by building (and testing) a 32-bit JDK on my Linux x64 using `--with-target-bits=32`.

Marked as reviewed by jvernee (Committer).

test/jdk/java/foreign/callarranger/TestWindowsCallArranger.java line 28:

> 26:  * @test
> 27:  * @enablePreview
> 28:  * @requires ((os.arch == "amd64" | os.arch == "x86_64") & sun.arch.data.model == "64") | os.arch == "aarch64"

Some of the other call arranger tests just use `@requires sun.arch.data.model == "64"`. Please do that here as well. It should be fine to run this test as long as the platform is 64 bit.
Suggestion:

 * @requires sun.arch.data.model == "64"

-------------

PR Review: https://git.openjdk.org/panama-foreign/pull/828#pullrequestreview-1395734752
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/828#discussion_r1173746366