[foreign-memaccess+abi] RFR: 8306668: Some foreign tests fail on x86 [v2]

[Jorn Vernee]

On Fri, 21 Apr 2023 13:06:45 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/java/foreign/callarranger/TestWindowsCallArranger.java
>>   
>>   Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>
>
> test/jdk/java/foreign/callarranger/TestWindowsCallArranger.java line 28:
> 
>> 26:  * @test
>> 27:  * @enablePreview
>> 28:  * @requires ((os.arch == "amd64" | os.arch == "x86_64") & sun.arch.data.model == "64") | os.arch == "aarch64"
> 
> Some of the other call arranger tests just use `@requires sun.arch.data.model == "64"`. Please do that here as well. It should be fine to run this test as long as the platform is 64 bit.
> Suggestion:
> 
>  * @requires sun.arch.data.model == "64"

FWIW, the underlying issue with this test is that the size of the address layout changes across platforms.

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/828#discussion_r1173759259