[foreign-memaccess+abi] RFR: 8313894: Rename isTrivial linker option to critical

Jorn Vernee jvernee at openjdk.org
Mon Aug 7 18:14:15 UTC 2023


The name `isTrivial` isn't ideal.

The 'is' can be dropped, and we'd like to switch to the name 'critical' which leans on an established meaning (JNI GetPrimitiveArrayCritical, java criticals).

All in all, the goal of the name is to avoid making too many promises about what this option does (although that is covered by the javadoc). It is intended to act more as a hint to the runtime. For instance, on x64 it will elide the thread state transition done by a native call, but this is not the case on all implementations (e.g. the fallback linker).

-------------

Commit messages:
 - rename trivial -> critical

Changes: https://git.openjdk.org/panama-foreign/pull/859/files
 Webrev: https://webrevs.openjdk.org/?repo=panama-foreign&pr=859&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8313894
  Stats: 334 lines in 13 files changed: 143 ins; 143 del; 48 mod
  Patch: https://git.openjdk.org/panama-foreign/pull/859.diff
  Fetch: git fetch https://git.openjdk.org/panama-foreign.git pull/859/head:pull/859

PR: https://git.openjdk.org/panama-foreign/pull/859


More information about the panama-dev mailing list