[foreign-memaccess+abi] RFR: 8313894: Rename isTrivial linker option to critical

[Per Minborg]

On Mon, 7 Aug 2023 17:21:45 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> The name `isTrivial` isn't ideal.
> 
> The 'is' can be dropped, and we'd like to switch to the name 'critical' which leans on an established meaning (JNI GetPrimitiveArrayCritical, java criticals).
> 
> All in all, the goal of the name is to avoid making too many promises about what this option does (although that is covered by the javadoc). It is intended to act more as a hint to the runtime. For instance, on x64 it will elide the thread state transition done by a native call, but this is not the case on all implementations (e.g. the fallback linker).

LGTM. I think the new name is an improvement.

-------------

Marked as reviewed by pminborg (Committer).

PR Review: https://git.openjdk.org/panama-foreign/pull/859#pullrequestreview-1565962104