[vectorIntrinsics+fp16] RFR: 8300571: FP16 support for VectorAPI Transcendental operations.

[Jatin Bhateja]

On Thu, 19 Jan 2023 09:13:14 GMT, Swati Sharma <duke at openjdk.org> wrote:

> Hi All,
> 
> The patch contains the below changes:
> •	Support for Transcendental routines for FP16 type.
> •	Re-enabling earlier commented out JTREG tests. 
> 
> Please review and provide your feedback.
> 
> Thanks,
> Swati

test/jdk/jdk/incubator/vector/templates/Unit-header.template line 757:

> 755:         float low = Math.nextDown(exp);
> 756:         float high = Math.nextUp(exp);
> 757: 

Here upcasting the result to float will check against the ULP of Float not Halffloat. But given that ULP of FP32 is always greater than ULP of FP16 intended functionality should still be honored.  

Another observation we should be using an expression like   Math.abs((expected + Math.ulp(expected)) - actual)) <= Math.ulp(expected), but this is not related to current patch, since patch just enable existing JTREG tests for FP16.

-------------

PR: https://git.openjdk.org/panama-vector/pull/209