[vectorIntrinsics+fp16] RFR: 8300571: FP16 support for VectorAPI Transcendental operations.
Jatin Bhateja
jbhateja at openjdk.org
Wed Jan 25 10:25:39 UTC 2023
On Wed, 25 Jan 2023 08:11:01 GMT, Swati Sharma <duke at openjdk.org> wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 852:
>>
>>> 850: v0.uOp(m, (i, a) -> Halffloat.valueOf((float) Math.cosh(Halffloat.valueOf(a).floatValue())));
>>> 851: case VECTOR_OP_TANH: return (v0, m) ->
>>> 852: v0.uOp(m, (i, a) -> Halffloat.valueOf((float) Math.tanh(Halffloat.valueOf(a).floatValue())));
>>
>> All the Math.* transcendental routines accept a double argument, you can directly use Float.float16ToFloat() instead of Halffloat.valueOf(a).floatValue(), argument will get upcasted to double.
>
> A separate patch is there to replace at all places Halffloat.valueOf(a).floatValue() with Float.float16ToFloat() , Should I do the replacement changes in this patch at all places.
I do not see any harm in updating this patch with suggested changes, for existing checked in code a separate patch can be released.
-------------
PR: https://git.openjdk.org/panama-vector/pull/209
More information about the panama-dev
mailing list