[foreign-memaccess+abi] RFR: 8312615: Ensure jdk_foreign tests pass on linux-x86

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Jul 25 01:05:02 UTC 2023


On Tue, 25 Jul 2023 00:55:48 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> test/jdk/java/foreign/NativeTestHelper.java line 133:
>> 
>>> 131:     // Common layout shared by some tests
>>> 132:     // struct S_PDI { void* p0; double p1; int p2; };
>>> 133:     public static final MemoryLayout S_PDI_LAYOUT = switch ((int) ValueLayout.ADDRESS.byteSize()) {
>> 
>> I don't see differences between the two layouts created in the two cases?
>
> The first one has 4 extra bytes of padding

Doh - I was looking for padding, but was distracted by the capitalization of the various constants :-)

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/849#discussion_r1272891396


More information about the panama-dev mailing list