[foreign-memaccess+abi] RFR: 8312615: Ensure jdk_foreign tests pass on linux-x86 [v2]
Jorn Vernee
jvernee at openjdk.org
Tue Jul 25 13:15:35 UTC 2023
On Tue, 25 Jul 2023 00:56:11 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> test/jdk/java/foreign/NativeTestHelper.java line 129:
>>
>>> 127: * The layout for the {@code size_t} C type
>>> 128: */
>>> 129: public static final ValueLayout C_SIZE_T = ValueLayout.ADDRESS.byteSize() == 8 ? C_LONG_LONG : C_INT;
>>
>> Can't you set SIZE_T using the canonical layout API?
>
> True. We could change the other layouts in this file over to that too.
I've update this list of layouts to use canonicalLayouts() instead
-------------
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/849#discussion_r1273521107
More information about the panama-dev
mailing list