[foreign-memaccess+abi] RFR: 8305087: MemoryLayout API checks should be more eager [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Mar 28 16:56:39 UTC 2023


> This patch adds eager check on construction of sequence and group layouts. More specifically:
> 
> * sequenceLayout(L) is well-formed iff L.bitAlignment() <= L.bitSize()
> * groupLayout(L1, … Ln) is well-formed iff for-each 1..n, offset(Li) % Li.bitAlignment() == 0
> 
> Moreover, this patch also validates the alignment parameter to calls of `MemoryLayout::withBitAlignment` on sequence and group layouts:
> 
> * sequenceLayout(L).withBitAlignment(a) is well-formed iff L.bitAlignment() <= a
> * groupLayout(L1, ..., Ln).withBitAlignment(a) is well-formed iff max(L1.bitAlignment(), ...,  Ln.bitAlignment()) <= a
> 
> These checks prevent bad layouts from being constructed (either with factories, or with bad calls to `withBitAlignment`), w/o restricting the expressiveness of the memory layout API.
> Moreover, since all layouts are now well-formed by construction, we no longer need lazy checks when creating a deferefence var handle.

Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:

  Update src/java.base/share/classes/java/lang/foreign/GroupLayout.java
  
  Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/panama-foreign/pull/824/files
  - new: https://git.openjdk.org/panama-foreign/pull/824/files/ff3e5323..49b83016

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=panama-foreign&pr=824&range=01
 - incr: https://webrevs.openjdk.org/?repo=panama-foreign&pr=824&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/panama-foreign/pull/824.diff
  Fetch: git fetch https://git.openjdk.org/panama-foreign.git pull/824/head:pull/824

PR: https://git.openjdk.org/panama-foreign/pull/824


More information about the panama-dev mailing list