[foreign-memaccess+abi] RFR: 8305087: MemoryLayout API checks should be more eager [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Mar 28 16:56:43 UTC 2023


On Tue, 28 Mar 2023 16:16:14 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/java.base/share/classes/java/lang/foreign/GroupLayout.java
>>   
>>   Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>
>
> src/java.base/share/classes/java/lang/foreign/GroupLayout.java line 71:
> 
>> 69:      * {@inheritDoc}
>> 70:      * @throws IllegalArgumentException {@inheritDoc}
>> 71:      * @throws IllegalArgumentException if {@code bitAlignment} is {@code M}, where {@code M} is the maximum alignment
> 
> Typo?
> Suggestion:
> 
>      * @throws IllegalArgumentException if {@code bitAlignment} is less than {@code M}, where {@code M} is the maximum alignment

Good catch

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/824#discussion_r1150908270


More information about the panama-dev mailing list