[foreign-memaccess+abi] RFR: 8305369: Issues in zero-length memory segment javadoc section [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Mar 31 15:43:58 UTC 2023
> This patch addresses a number of issue in the zero-length memory segment javadoc section:
>
> * there are some typo in the code samples (e.g. extra semi-colons);
> * variable names are off (e.g. spurious references to a `foreign` segment variable);
> * the explanation of how a pointer is read from a segment is lacking, and could be clarified;
> * it would be useful to have links to other section (e.g. in the Linker javadoc) which also deal with ZLMS.
Maurizio Cimadamore has updated the pull request incrementally with four additional commits since the last revision:
- Fix indent of comments
- Replace get w/ getAtIndex (to make it uniform)
- Drop extra space in var declarations
- Address review comments
-------------
Changes:
- all: https://git.openjdk.org/panama-foreign/pull/825/files
- new: https://git.openjdk.org/panama-foreign/pull/825/files/ba3818f6..ca02073b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=panama-foreign&pr=825&range=01
- incr: https://webrevs.openjdk.org/?repo=panama-foreign&pr=825&range=00-01
Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod
Patch: https://git.openjdk.org/panama-foreign/pull/825.diff
Fetch: git fetch https://git.openjdk.org/panama-foreign.git pull/825/head:pull/825
PR: https://git.openjdk.org/panama-foreign/pull/825
More information about the panama-dev
mailing list