[foreign-memaccess+abi] RFR: 8305369: Issues in zero-length memory segment javadoc section [v2]

Jorn Vernee jvernee at openjdk.org
Fri Mar 31 15:58:42 UTC 2023


On Fri, 31 Mar 2023 15:43:58 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch addresses a number of issue in the zero-length memory segment javadoc section:
>> 
>> * there are some typo in the code samples (e.g. extra semi-colons);
>> * variable names are off (e.g. spurious references to a `foreign` segment variable);
>> * the explanation of how a pointer is read from a segment is lacking, and could be clarified;
>> * it would be useful to have links to other section (e.g. in the Linker javadoc) which also deal with ZLMS.
>
> Maurizio Cimadamore has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Fix indent of comments
>  - Replace get w/ getAtIndex (to make it uniform)
>  - Drop extra space in var declarations
>  - Address review comments

Marked as reviewed by jvernee (Committer).

-------------

PR Review: https://git.openjdk.org/panama-foreign/pull/825#pullrequestreview-1367203727


More information about the panama-dev mailing list