[foreign-memaccess+abi] RFR: 8291639: Improve the ability to visualize a MemorySegment in human readable forms [v2]
Rémi Forax
forax at openjdk.org
Fri May 26 13:15:30 UTC 2023
On Fri, 26 May 2023 13:06:57 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to add a "Record Mapper" that allows `MemorySegment` instances to be projected onto `Record` types given `GroupLayout` instances.
>>
>> Here is a simple example of how to use the mapper:
>>
>>
>> private static final GroupLayout POINT_LAYOUT = MemoryLayout.structLayout(
>> JAVA_INT.withName("x"),
>> JAVA_INT.withName("y"));
>>
>> MemorySegment segment = MemorySegment.ofArray(new int[]{3, 4});
>>
>> Point point = POINT_LAYOUT.recordMapper(Point.class)
>> .apply(segment); // Point[x=3, y=4]
>>
>>
>> I think the implementation can be improved later, for example by de-duplicating handling of arrays and maybe add recursive "un-pealing" of multidimensional arrays.
>
> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
>
> - Merge master
> - Fix typos
> - Clean up toString methods
> - Add support for MemoryAddress arrays and improve docs
> - Improve javadoc
> - Change to IAE if mapper fails
> - Remove caching
> - Add tests for initial issue examples
> - Clean up and optimize
> - Add support for multidimensional records
> - ... and 19 more: https://git.openjdk.org/panama-foreign/compare/bee4503b...1d7db589
src/java.base/share/classes/jdk/internal/foreign/LayoutRecordMapper.java line 224:
> 222: case GroupLayout gl -> {
> 223: @SuppressWarnings("unchecked")
> 224: var arrayComponentType = (Class<? extends Record>) deepArrayComponentType(cl.component.getType());
use Class.asSubclass() instead of the unchecked cast
-------------
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/833#discussion_r1206762935
More information about the panama-dev
mailing list