[foreign-memaccess+abi] RFR: 8291639: Improve the ability to visualize a MemorySegment in human readable forms [v2]
Per Minborg
pminborg at openjdk.org
Fri May 26 15:27:17 UTC 2023
On Fri, 26 May 2023 13:09:13 GMT, Rémi Forax <forax at openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
>>
>> - Merge master
>> - Fix typos
>> - Clean up toString methods
>> - Add support for MemoryAddress arrays and improve docs
>> - Improve javadoc
>> - Change to IAE if mapper fails
>> - Remove caching
>> - Add tests for initial issue examples
>> - Clean up and optimize
>> - Add support for multidimensional records
>> - ... and 19 more: https://git.openjdk.org/panama-foreign/compare/bee4503b...1d7db589
>
> src/java.base/share/classes/jdk/internal/foreign/LayoutRecordMapper.java line 123:
>
>> 121: // where X is the component type.
>> 122: MethodHandle[] handles = componentAndLayoutList.stream()
>> 123: .map(cl -> {
>
> map() + filter(Object::isNull) should be a flatMap() or a mapMulti()
The filter operation should be removed.
-------------
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/833#discussion_r1206954148
More information about the panama-dev
mailing list