[foreign-memaccess+abi] RFR: Modernize code

[Maurizio Cimadamore]

On Fri, 22 Sep 2023 13:40:38 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to modernize some parts of the code with constructs from newer Java versions.

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 728:

> 726:     }
> 727: 
> 728:     static long make(int offset, int scale) {

Maybe let's just use a record for this? Escape analysis should work fine when it matters. Or, even better, the record could declare a bunch of static constants (e.g. for char, int, long, ...) and just return the appropriate constant given the switch type (e.g. so that there's no allocation).

src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/TypeClass.java line 211:

> 209:     }
> 210: 
> 211:     private static void groupByEightBytes(MemoryLayout l, long offset, List<ArgumentClassImpl>[] groups) {

please rename `l` to `layout`

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/894#discussion_r1334503784
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/894#discussion_r1334508705