[foreign-memaccess+abi] RFR: Modernize code

[Maurizio Cimadamore]

On Fri, 22 Sep 2023 15:03:53 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR proposes to modernize some parts of the code with constructs from newer Java versions.
>
> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 728:
> 
>> 726:     }
>> 727: 
>> 728:     static long make(int offset, int scale) {
> 
> Maybe let's just use a record for this? Escape analysis should work fine when it matters. Or, even better, the record could declare a bunch of static constants (e.g. for char, int, long, ...) and just return the appropriate constant given the switch type (e.g. so that there's no allocation).

Also, we call `.getClass()` on the `Object` array passed in, which then makes the switch more complex (e.g. as it needs `when`). Would it be better to just pass the object "as is", and then switch on the object type instead?

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/894#discussion_r1334507237