RFR(S): 8028514: PPC64: Fix C++ Interpreter after '7195622: CheckUnhandledOops has limited usefulness now'

[Lois Foltan]

Hi Volker,

I do have a few review comments:

   src/cpu/ppc/vm/frame_ppc.cpp
     - The "cast_to_oop<void *>(NULL)" I believe could be simplified to 
"(oop)NULL" see similar code in
        src/cpu/x86/vm/frame_x86.cpp.

   src/share/vm/interpreter/bytecodeInterpreter.cpp
     - I have attached the recent RFR for supporting 
CHECK_UNHANDLED_OOPS across the platforms.
       It contains the summary outlining the changes.  Please change 
your "cast_from_oop<uintptr_t>"
       within tty->print_cr() to "(void *)" as described in summary note 
item #3.

Thank you,
Lois

On 11/18/2013 11:45 AM, Volker Simonis wrote:
> Hi,
>
> could you please review the following small webrev which fixes the
> CPP-interpreter after "CheckUnhandledOops" was re-enabled in the
> fastdebug build:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8028514/
>
> All the changes are in CPP-interpreter specific files or in code which
> is protected by "#ifdef  CC_INTERP". Most changes just switch
> old-style "(oop)"casts to new-style "cast_to_oop()" conversions.
>
> Thank you and best regards,
> Volker

-------------- next part --------------
An embedded message was scrubbed...
From: Lois Foltan <lois.foltan at oracle.com>
Subject: FR (L) JDK-7195622 (round 2): CheckUnhandledOops has limited
	usefulness now
Date: Mon, 23 Sep 2013 17:17:05 -0400
Size: 15886
Url: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20131118/3c3712da/FRLJDK-7195622round2CheckUnhandledOopshaslimitedusefulnessnow-0001.eml