RFR(S): 8028514: PPC64: Fix C++ Interpreter after '7195622: CheckUnhandledOops has limited usefulness now'
Volker Simonis
volker.simonis at gmail.com
Tue Nov 19 02:09:22 PST 2013
Hi David,
I've changed the cast to (void*) as suggested by Lois.
Thanks,
Volker
On Tue, Nov 19, 2013 at 2:32 AM, David Holmes <david.holmes at oracle.com> wrote:
> On 19/11/2013 2:45 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> could you please review the following small webrev which fixes the
>> CPP-interpreter after "CheckUnhandledOops" was re-enabled in the
>> fastdebug build:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8028514/
>>
>> All the changes are in CPP-interpreter specific files or in code which
>> is protected by "#ifdef CC_INTERP". Most changes just switch
>> old-style "(oop)"casts to new-style "cast_to_oop()" conversions.
>
>
> Why do we have use of INTPTR_FORMAT but a cast_from_oop<uintptr_t> ? ie
> mixing signed with unsigned.
>
> Otherwise looks ok.
>
> Thanks,
> David
>
>
>> Thank you and best regards,
>> Volker
>>
>
More information about the ppc-aix-port-dev
mailing list