RFR (XS): 8032634: Add #ifdef PPC64 around OrderAccess operations on _thread_state.

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jan 24 06:56:33 PST 2014


Thanks. I will push it using JPRT.

Vladimir

On 1/24/14 6:54 AM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> I updated it.
>
> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Freitag, 24. Januar 2014 15:36
> To: Lindenmaier, Goetz; 'hotspot-dev at openjdk.java.net'; 'ppc-aix-port-dev at openjdk.java.net'; David Holmes
> Subject: Re: RFR (XS): 8032634: Add #ifdef PPC64 around OrderAccess operations on _thread_state.
>
> Why you used #if !defined() instead of #ifndef? We usually use #ifndef when checking one parameter.
>
> Thanks,
> Vladimir
>
> On 1/24/14 1:42 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> please review and test this small change:
>>
>> http://cr.openjdk.java.net/~goetz/webrevs/8032634-1-ifdef/
>>
>> Please also review it for jdk8u.
>>
>> There are concerns that the OrderAccess operations we added to accesses of
>>
>> _/thead/_state for ppc64 harm performance on other platforms.  Thus this change adds
>>
>> guards #ifdef PPC64 around it.
>>
>> Best regards,
>>
>>     Goetz.
>>


More information about the ppc-aix-port-dev mailing list