RFR: 8214205: PPC64: Add instructions for counting trailing zeros

Michihiro Horie HORIE at jp.ibm.com
Thu Nov 22 11:37:20 UTC 2018


Hi Martin,

Thank you for your review and the complement for my insufficient FFR
format.

I updated the webrev, which now has no "_Ex" and updated copyright year.
http://cr.openjdk.java.net/~mhorie/8214205/webrev.01/

Gustavo,
Could you review this change with testing and also push it when it's good?


Best regards,
--
Michihiro,
IBM Research - Tokyo



From:	"Doerr, Martin" <martin.doerr at sap.com>
To:	Michihiro Horie <HORIE at jp.ibm.com>,
            "ppc-aix-port-dev at openjdk.java.net"
            <ppc-aix-port-dev at openjdk.java.net>,
            "'hotspot-compiler-dev at openjdk.java.net'"
            <hotspot-compiler-dev at openjdk.java.net>
Cc:	Gustavo Romero <gromero at linux.vnet.ibm.com>
Date:	2018/11/22 19:21
Subject:	RE: RFR: 8214205: PPC64: Add instructions for counting trailing
            zeros



Hi Michihiro,

this change needs to get reviewed on hotspot-compiler-dev (added).
Also added missing „RFR“.

The change looks good. I only have very minor requests:
“_Ex” should be removed from the new instruct names. They aren’t expand
rules.
Please also update the copyright year in the header of the ad file.

Maybe Gustavo can test it, write a 2nd review and push it when it’s good.

Best regards,
Martin


From: Michihiro Horie <HORIE at jp.ibm.com>
Sent: Donnerstag, 22. November 2018 06:40
To: ppc-aix-port-dev at openjdk.java.net
Cc: Gustavo Romero <gromero at linux.vnet.ibm.com>; Doerr, Martin
<martin.doerr at sap.com>
Subject: RFR: 8214205: PPC64: Add instructions for counting trailing zeros



Dear all,

Would you please review the following change that enables POWER9’s
instructions for counting trailing zeros?

Bug: https://bugs.openjdk.java.net/browse/JDK-8214205
Webrev: http://cr.openjdk.java.net/~mhorie/8214205/webrev.00/

Simple micro benchmark attached showed improvements by around 30%.
(See attached file: CNTTZTest.java)

Currently, Gustavo at IBM can test POWER9 specific changes. (Thanks Gustavo!)


Best regards,
--
Michihiro,
IBM Research - Tokyo





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20181122/75e9c5a8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20181122/75e9c5a8/graycol.gif>


More information about the ppc-aix-port-dev mailing list