[riscv-port] RFR: 8278033: riscv: Fix MacroAssembler::atomic_incw: store condition instruction has wrong operand order

Aleksey Shipilev shade at openjdk.java.net
Wed Dec 1 10:02:49 UTC 2021


On Wed, 1 Dec 2021 02:40:31 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> This is a trivial fix for this typo. This could reproduce before JDK18 by using `-XX:+PrintBiasedLockingStatistics`; however, after the removal of BiasedLocking, this function has no usage now. But we might fix it as well for future usage since it is a quite fundamental function. [The original patch](https://github.com/riscv-collab/riscv-openjdk/pull/11)

The line above should read "will be zero", right?

Also, shouldn't it be `lr_w(..., acquire)` and `sc_w(..., release)`? I suppose `atomic_incw` has to carry the memory semantics...

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/19


More information about the riscv-port-dev mailing list