[riscv-port] RFR: 8278833: riscv: Remove the x3 and x4 register saving logic in register savers [v3]

Xiaolin Zheng xlinzheng at openjdk.java.net
Thu Dec 16 08:07:26 UTC 2021


On Thu, 16 Dec 2021 03:06:42 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

>> Hi team,
>> 
>> x3 is the global pointer register used to reference global variables in C++ code, generated by linker; and x4 is the thread pointer register and would be modified by the kernel. In the riscv-port repo, we have no other modifications for the x3 & x4 registers so I would recommend removing the x3 & x4 saving logic in register savers. Previously verified along with other patches under full tiers jdk/hotspot on boards, and verified a simple `test/jtreg/hotspot/compiler` after fixing conflicts with [JDK-8278337](https://github.com/openjdk/riscv-port/pull/25).
>> 
>> BTW since we remove both two registers together, sp remains 16-byte aligned without other changes in stack frames.
>> 
>> Thanks,
>> Xiaolin
>
> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Further fix comments for JDK-8278337

Thanks for the reviews, team.

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/31


More information about the riscv-port-dev mailing list