[riscv-port] RFR: 8278644: riscv: Intrinsify mulAdd [v2]
guotaiping1
duke at openjdk.java.net
Tue Dec 21 09:06:26 UTC 2021
On Tue, 21 Dec 2021 08:40:30 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> change the type of i in for loop to match the type of unroll
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 3049:
>
>> 3047: Register len, Register k, Register tmp) {
>> 3048: Label L_tail_loop, L_unroll, L_end;
>> 3049: mv(tmp, out);
>
> I think this "mv" instruction could be moved after the zero check for"len". Then we will save one instruction when "len" is zero.
Thanks for your review, but if the `mv(tmp, out)` instruction is moved after `beqz(len, L_end)`, the `tmp` in `add(offset, tmp, t0)` is not as expected because of the `mv(out, zr)` before `beqz(len, L_end)`.
-------------
PR: https://git.openjdk.java.net/riscv-port/pull/36
More information about the riscv-port-dev
mailing list