[riscv-port] RFR: 8281632: riscv: Improve interpreter stack banging [v4]
yadongwang at openjdk.java.net
Thu Feb 24 06:25:41 UTC 2022
On Tue, 22 Feb 2022 06:55:48 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Yadong Wang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> missing check for stack growth watermark
> src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp line 922:
>> 921: // Record a new watermark, unless the update is above the safe limit.
>> 922: // Otherwise, the next time around a check above would pass the safe limit.
> Hah. I noticed this is worded incorrectly in the original x86 change. See https://github.com/openjdk/jdk/pull/7569 -- probably makes sense to wait a bit for that change to land, and then pick up the same wording here?
OK, I've synchronized it, and wait for your patch to be merged.
More information about the riscv-port-dev