[riscv-port] RFR: 8278994: riscv: RVC support [v8]
Xiaolin Zheng
xlinzheng at openjdk.java.net
Thu Jan 6 11:33:27 UTC 2022
On Thu, 6 Jan 2022 09:46:25 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove remaining macros as discussions
>
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 1858:
>
>> 1856:
>> 1857: // --------------------------
>> 1858: // sub/subw -> c.sub/c.subw
>
> It's better to move this comment before the if block which does compression.
Thanks for pointing out this and I have moved them before every if block. A trivial detail might be that we need to use `/**/` inside macros instead of `//`. Also fixed other comments.
-------------
PR: https://git.openjdk.java.net/riscv-port/pull/34
More information about the riscv-port-dev
mailing list