[riscv-port] RFR: 8278994: riscv: RVC support [v10]

Xiaolin Zheng xlinzheng at openjdk.java.net
Mon Jan 10 07:30:28 UTC 2022


On Mon, 10 Jan 2022 07:14:52 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Yes, I agree with your point. That trampoline part is special and requires to be scrupulous to make changes.
>> 
>> So maybe I'd better remove the `nmethod_barrier_guard_offset` part right?
>
> Yes. Please also update the code comments. It looks strange to find those comments starts with a "RVC:".
> Also we should make the exact alignment required explicit in comments like: "RISCV's amoswap instructions need an alignment for the memory address it swaps" or "RISCV CAS needs an alignment for memory", etc.

done - polished and it needs some testing works.

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/34


More information about the riscv-port-dev mailing list