[riscv-port] RFR: 8278994: riscv: RVC support [v18]

Xiaolin Zheng xlinzheng at openjdk.java.net
Mon Jan 17 12:30:49 UTC 2022


On Mon, 17 Jan 2022 11:42:28 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
>> 
>>  - Add an assertion for patchable jals' alignment
>>  - Polish comments: remove the 'RVC:' prefix
>>  - Polish `nmethod_entry_barrier` and RISC-V CAS related comments
>>  - Remove `nmethod_entry_barrier`-related things
>>  - Split c_ldsp and c_fldsp
>>  - Remove useless and polish comments
>>  - Move RVC code to the proper location after rebasing (#42)
>>  - Rename misc functions and change the positions of some comments
>>  - Remove remaining macros as discussions
>>  - Remain an 'minimum_alignment' unchanged
>>  - ... and 10 more: https://git.openjdk.java.net/riscv-port/compare/0e400fce...37899306
>
> src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1328:
> 
>> 1326:   // With RVC a call may get 2-byte aligned.
>> 1327:   //   the address of jal itself (which will be patched later) should not span the cache line.
>> 1328:   //   See CallStaticJavaDirectNode::compute_padding() for more info.
> 
> Suggestion:
>   // With RVC a call instruction (which will be patched later) may get 2-byte aligned and could
>   // span multiple cache lines. See CallStaticJavaDirectNode::compute_padding() for more info.

Thanks for spending time polishing my poor English :-) Revised all as suggestions, and it looks nicer than before.

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/34


More information about the riscv-port-dev mailing list