[riscv-port-jdk17u:riscv-port] RFR: 8295270: RISC-V: Clean up and refactoring for assembler functions [v2]

Gui Cao gcao at openjdk.org
Mon Apr 10 07:00:50 UTC 2023


On Mon, 10 Apr 2023 03:36:35 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

>> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add the missing IncompressibleRegion
>
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 496:
> 
>> 494:               "only internal_word_type relocs make sense here");            \
>> 495:     relocate(InternalAddress(dest).rspec());                                \
>> 496:     IncompressibleRegion ir(this);  /* relocations */
> 
> Here we have an `IncompressibleRegion` thing to keep instructions in `INSN_ENTRY_RELOC` from being compressed by the C extension, for relocations are here. But after moving to different locations in this patch, the `IncompressibleRegion` is missing. Please see the below comments.
> 
> This may be caused by the order of patch submission.

Thanks for the reivew, fixed.

-------------

PR Review Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/38#discussion_r1161486400


More information about the riscv-port-dev mailing list