[riscv-port-jdk17u:riscv-port] RFR: 8290496: riscv: Fix build warnings-as-errors with GCC 11
Vladimir Kempik
vkempik at openjdk.org
Tue Feb 28 09:02:39 UTC 2023
On Tue, 28 Feb 2023 08:47:53 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Your backport is clean so it doesn't need a review.
>> However, the process is not clear yet: who would approve backports in this project ? how to request approval ?
>> Also, Can anyone, who is already reviewer in jdk-updates-project become reviewer in riscv-port-jdk17u ?
>>
>> This Qs is not for @DingliZhang , but general one
>
> @VladimirKempik
>
> Here is what I am think about the backporting work flow for this repo.
> Since we are not upstreamed yet, I think we could follow a simplified workflow here. In fact, if you look at other projects like Lilliput or ZGC, they also follow a rather simplified flow for PR integration. In these cases, Committers could also do code reviews [1] and you don't even need a JBS issue for creating a PR [2].
>
> Here in our case for riscv-port-jdk17u repo, I am not expecting uses of labels/comments on the JBS issue for request approvals, which is required by the upstreaming backporting flow. I think it's better to do that (like marking the JBS issues for requesting maintainer approvals) when we do the final upstreaming to jdk17u-dev repo.
> So any people who are familar with the riscv port could review a PR for riscv-port-jdk17u repo. When a backporting PR for this repo is clean or is fully reviewed, I could help do the final integration. I am open to other suggestions.
>
> [1] https://github.com/openjdk/lilliput/pull/67
> [2] https://github.com/openjdk/zgc/pull/1
Hello @RealFYang, thanks to explanation, however one moment isn't clear yet
In case of "clean" backports, can we request integration right away ?
-------------
PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2
More information about the riscv-port-dev
mailing list