[riscv-port-jdk17u:riscv-port] RFR: 8309427: [riscv-port-jdk17u] Remove unused RoundDoubleModeV C2 node

Gui Cao gcao at openjdk.org
Fri Jun 9 01:09:10 UTC 2023


On Thu, 8 Jun 2023 03:54:27 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hi, here we want to remove the RoundDoubleModeV node that is not being used, we found that the reason the RoundDoubleModeV node is not called in RISC-V is that the PopulateIndex node needs to be added to enable SuperWord optimization (an algorithm for automatic vectorization). In addition to this, the node RoundDoubleMode needs to be implemented in its scalar form, which is not implemented in riscv.ad. But there is no floating point to floating point instruction in riscv that does not change the width by, so what we need to do here may simply be to remove the RoundDoubleModeV node. refer: https://bugs.openjdk.org/browse/JDK-8298342
>> 
>> Testing:
>> 
>> Tier1-3 passed without new failure on unmacthed (release).
>
> Looks good. And I want to add that the assembly code for this node is not correct in using the rounding mode.

@RealFYang Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/68#issuecomment-1583724648


More information about the riscv-port-dev mailing list